🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19508

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• Run pull request jobs on OSDC runners in shadow mode

❌ 3 New Failures, 26 Pending, 1 Unrelated Failure

As of commit a76cd5c with merge base a142873 ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Hi @madhesh60!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@pytorchbot label "release notes: none"

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

There are few lint errors that need to be resolved before it can land

@claude review the task and this PR

Claude finished @psiddh's task in 3m 7s —— View job

PR Review: docs(android) - Java API Reference (Javadoc)

• Gather context and read changed files
• Review documentation changes (markdown files)
• Review Java source changes (package-info.java files)
• Review build configuration changes (build.gradle)
• Review new file (overview.html)
• Check lint failures and provide recommendations
• Post final review

Overall Assessment

The intent of this PR is good — adding Javadoc overview content, sidebar navigation, and linking to the API reference. However, there are 2 CI failures caused by this PR that must be fixed before landing:

CI Failure #1: android-java-format

Both package-info.java files fail google-java-format checks. Fix by running:

google-java-format -i \
  extension/android/executorch_android/src/main/java/org/pytorch/executorch/package-info.java \
  extension/android/executorch_android/src/main/java/org/pytorch/executorch/extension/llm/package-info.java

CI Failure #2: link-check / lint-urls

Three URLs introduced by this PR return 404:

Suggested fixes:

• Remove or replace the cross-compilation-for-android.html link (the page doesn't exist)
• Update the demo app links to point to https://github.com/meta-pytorch/executorch-examples (e.g., https://github.com/meta-pytorch/executorch-examples/tree/main/llm/android/LlamaDemo for the Llama demo)

Code Review Notes

docs/source/android-section.md — Looks good. The addition of :maxdepth: 1 and the closing ``` fence is a nice fix (the original toctree was technically unclosed). The external toctree entry for Javadoc is correct syntax.

docs/source/using-executorch-android.md — Minor change from /javadoc/ to /javadoc/index.html. The link-check shows this resolves (200 OK), so this is fine.

extension/android/executorch_android/build.gradle — The Javadoc task generation looks reasonable. One minor concern: variant.name.capitalize() is deprecated in Groovy 4+ (which newer Gradle versions use). Consider using variant.name.capitalize() with a note or switch to variant.name.substring(0,1).toUpperCase() + variant.name.substring(1) for future-proofing. Not blocking.

package-info.java files — Content is high quality with good quick-start examples and {@link} references to real classes (all verified to exist). The only issues are formatting (see CI failure above) and broken external links.

overview.html — Clean HTML with useful package summary table. Same broken link issues as above.

Summary

The content quality is solid. To land this PR, @madhesh60 needs to:

1. Run google-java-format -i on both package-info.java files
2. Fix/remove the 3 broken URLs (dead cross-compilation page + moved demo-apps links)

Agree with Claude review, fix the two broken CI issues + rebase and this should be good to land. lgtm overall.
Thanks for your contribution @madhesh60

@psiddh Thanks for the review! I will fix them and update the broken links. Will push the changes shortly.

Hi @psiddh, while fixing the broken links, I noticed the CI also flagged a 404 in a completely different file docs/source/backends/arm-ethos-u/arm-ethos-u-overview.md is pointing to https://docs.pytorch.org/executorch/stable/tutorial-arm-ethos-u.html which no longer exists.

This is unrelated to my changes. Should I fix this as part of this PR, or would you prefer I open a separate issue for it?

Hi @psiddh, while fixing the broken links, I noticed the CI also flagged a 404 in a completely different file docs/source/backends/arm-ethos-u/arm-ethos-u-overview.md is pointing to https://docs.pytorch.org/executorch/stable/tutorial-arm-ethos-u.html which no longer exists.

This is unrelated to my changes. Should I fix this as part of this PR, or would you prefer I open a separate issue for it?

Would be nice if you can, o/w not sure how we can get past this CI error

@psiddh sir, I have resolved the CI and also synced with the latest main branch to clear the link-check errors.
The PR is ready for your final review. Thank You.

Workflows were awaiting approval. CI has now been triggered for the ciflow labels on this PR.

@psiddh Due to a few CI failures, I have committed a few new changes. Please review them.

@psiddh Due to a few CI failures, I have committed a few new changes. Please review them.

done, you can merge it now

@psiddh Some CI checks are failing on my PR again and again. Could you review and suggest how to resolve them properly?

• #### pull / unittest / macos / macos-job (push)Failing after 17m More actions
• #### trunk / test-huggingface-transformers-macos (distilbert|coreml_fp32_gpu|--quantize) / macos-job (push)Failing after 1m More actions
• #### trunk / test-models-macos-cpu (mobilebert, xnnpack-quantization-delegation) / macos-job (push)Failing after 6m More actions
• #### trunk / test-models-macos-cpu (mv3, portable) / macos-job (push)Failing after 6m More actions
• #### trunk / test-models-macos-cpu (resnet50, xnnpack-quantization-delegation) / macos-job (push)Failing after 6m

@psiddh Some CI checks are failing on my PR again and again. Could you review and suggest how to resolve them properly?

These failures are unrelated to your PR

pull / unittest / macos / macos-job (push)
pull / unittest / macos / macos-job (push)Failing after 17m
trunk / test-huggingface-transformers-macos (distilbert|coreml_fp32_gpu|--quantize) / macos-job (push)
trunk / test-huggingface-transformers-macos (distilbert|coreml_fp32_gpu|--quantize) / macos-job (push)Failing after 1m
trunk / test-models-macos-cpu (mobilebert, xnnpack-quantization-delegation) / macos-job (push)
trunk / test-models-macos-cpu (mobilebert, xnnpack-quantization-delegation) / macos-job (push)Failing after 6m
trunk / test-models-macos-cpu (mv3, portable) / macos-job (push)
trunk / test-models-macos-cpu (mv3, portable) / macos-job (push)Failing after 6m
trunk / test-models-macos-cpu (resnet50, xnnpack-quantization-delegation) / macos-job (push)
trunk / test-models-macos-cpu (resnet50, xnnpack-quantization-delegation) / macos-job (push)Failing after 6m

@psiddh I have rebased with latest main but the same macos jobs are still failing. Please let me know if I should wait or if anything is needed.